On 08/02/11 15:47, Thiago Macieira wrote: >>>> that's not so easy when you are confronted with entire branches. >>> >>> I guess that revision-to-revision diffs wouldn't be used for full branch >>> reviews, but it's useful to have it anyway. If a suggestion is made to >>> change only a few things, I'd like to quickly see what changes were >>> made since the contribution was last submitted. >> >> the point is that every submission is a branch. a single commit is a >> special case (even if a somewhat common one). so the system would have >> to employ some heuristics trying to match up commits. in the easiest >> case it could simply give up on anything which has more than one commit, >> but this would severely limits its usefulness. > > Right. If you reorder the commits, then revision-to-revision diffs would be > complete nonsense. > > But if you just edited some of the commits and changed the spelling or naming > of a method, then I'd like to see the diff.
Depends how the diffs work, too. If they treat the 'diff' as a merge of your contribution onto the original work, and then diff that.. i.e. something like: git checkout foo git checkout -b foo-v1 git merge v1 git checkout foo git checkout -b foo-v2 git merge v2 git diff foo-v1..foo-v2 then you have something reasonably meaningful. no? -- Robin Burchell - http://rburchell.com Software Engineer, Collabora Ltd. - http://collabora.co.uk _______________________________________________ Opengov mailing list Opengov@qt-labs.org http://lists.qt-labs.org/listinfo/opengov
