Roland, What is the status of the FMR patch? When do you expect it to be on the trunk?
Thanks Tziporet -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Vu Pham Sent: Monday, May 08, 2006 10:12 PM To: Roland Dreier Cc: [email protected] Subject: Re: [openib-general][patch review] srp: fmr implementation, Roland Dreier wrote: > Vu> This fmr patch does not work for ia64 system because this > Vu> fmr_page_mask is defined as unsigned int. > > Great catch! > > Vu> We should type cast it to u64 or define it as unsigned long > > Casting it won't help because it will just get zero-extended. I think > we need the following in ib_srp.h: > > unsigned long fmr_page_mask; > > and then in ib_srp.c: > > srp_dev->fmr_page_mask = ~((unsigned long) srp_dev->fmr_page_size - 1); > > does this work for you? > Yes. Please commit the final fmr patch. Thanks, Vu _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
