Hi Nir,

Thank you for taking care of this.

-- Kevin


Nir Lisker wrote:
Iv'e done some house cleaning and linked whatever I found. Should have caused a decent amount of notification spam...

- Nir

On Wed, Apr 4, 2018 at 8:10 PM, Kevin Rushforth <kevin.rushfo...@oracle.com <mailto:kevin.rushfo...@oracle.com>> wrote:

    I don't have a strong preference. The URL contains either "issue"
    or "pull" already, so there should be no confusion if we just use
    the URL.


    -- Kevin


    Nir Lisker wrote:
    github-bug is fine by me. What about external links, name them or
leave them as URLs?
    On Wed, Apr 4, 2018, 16:43 Johan Vos <johan....@gluonhq.com
    <mailto:johan....@gluonhq.com>> wrote:

        +1

        On Wed, Apr 4, 2018 at 3:30 PM Kevin Rushforth
        <kevin.rushfo...@oracle.com
        <mailto:kevin.rushfo...@oracle.com>> wrote:

            Any further comments on this? If not, then I propose we
            start using the
            JBS label:

                github-bug

            To identify JBS issues that are linked to guthub issues
            and/or PRs

            -- Kevin


            Nir Lisker wrote:
            > I think that the labels should be succinct, so one
            label should suffice.
            > Either github-link or github-bug are fine for me, the
            latter because there
            > is webbug label already. If a PR needs review just use
            the review-request
            > existing label.
            >
            > As for issues and PRs, the issue links section in the
            JIRA ticket could
            > reflect what exists in GitHub, so there can be 2 web
            links named "GitHub
            > issue" and "GitHub PR" if need be.
            >
            > - Nir
            >
            > On Thu, Mar 29, 2018 at 10:08 AM, Tom Schindl
            <tom.schi...@bestsolution.at
            <mailto:tom.schi...@bestsolution.at>>
            > wrote:
            >
            >
            >> well could we have 2:
            >> * github-issue
            >> * github-pr
            >>
            >> The first one indicates someone is working on it over
            at github, whereas
            >> the second means there's a PR that needs to be review.
            >>
            >> Tom
            >>
            >> On 29.03.18 08:42, Laurent Bourgès wrote:
            >>
            >>> Hi,
            >>>
            >>> As such github references point to either issue or
            PR, I recommend using
            >>> the term 'github-link'.
            >>>
            >>> Laurent
            >>>
            >>> Le jeu. 29 mars 2018 à 03:40, Kevin Rushforth <
            >>>
            >> kevin.rushfo...@oracle.com
            <mailto:kevin.rushfo...@oracle.com>>
            >>
            >>> a écrit :
            >>>
            >>>
            >>>> I think this would be fine. We would want something
            that didn't conflict
            >>>> with anything else and wasn't confusing. Possible
            choices:
            >>>>
            >>>> github-link
            >>>> github-bug
            >>>> gitbug-issue
            >>>>
            >>>> Any preferences?
            >>>>
            >>>> -- Kevin
            >>>>
            >>>>
            >>>> Nir Lisker wrote:
            >>>>
            >>>>> Kevin, can we get a label for this?
            >>>>>
            >>>>> - Nir
            >>>>>
            >>>>> On Mon, Mar 26, 2018 at 4:37 PM, Johan Vos
            <johan....@gluonhq.com <mailto:johan....@gluonhq.com>>
            >>>>>
            >>>> wrote:
            >>>>
            >>>>>
            >>>>>> Hi Nir,
            >>>>>>
            >>>>>> About 4. (jfx-dev): you're right, I just removed
            that repository. That
            >>>>>>
            >>>> was
            >>>>
            >>>>>> just some testing before we did the real thing.
            >>>>>>
            >>>>>> As for the other points: I agree
            >>>>>>
            >>>>>> - Johan
            >>>>>>
            >>>>>> On Mon, Mar 26, 2018 at 12:03 PM Nir Lisker
            <nlis...@gmail.com <mailto:nlis...@gmail.com>>
            >>>>>>
            >> wrote:
            >>
            >>>>>>
            >>>>>>> Hi All,
            >>>>>>>
            >>>>>>> A few comments about the mirror and JBS:
            >>>>>>>
            >>>>>>> 1. In PRs and issues on GitHub, I strongly
            suggest that the link to
            >>>>>>>
            >>>> JBS be
            >>>>
            >>>>>>> included in the top comment. If the JBS issue was
            created after a
            >>>>>>> discussion, edit it in.
            >>>>>>>
            >>>>>>> 2. In JBS, I suggest to link to the GitHub mirror
            via More > Link >
            >>>>>>>
            >> Web
            >>
            >>>>>>> Link and in the Link Text use something like
            "GitHub mirror" (open
            >>>>>>>
            >> for
            >>
            >>>>>>> suggestions). JIRA renders the link in an easy to
            see way (easier
            >>>>>>>
            >> than
            >>
            >>>>>>> looking at URLs). Iv'e tried it in a couple of
            issues, e.g.,
            >>>>>>> https://bugs.openjdk.java.net/browse/JDK-8198795
            <https://bugs.openjdk.java.net/browse/JDK-8198795> and it
            seems
            >>>>>>>
            >>>> preferable
            >>>>
            >>>>>>> to
            >>>>>>> me.
            >>>>>>>
            >>>>>>> 3. In JBS, I suggest a new label will be used for
            issues which are
            >>>>>>>
            >>>> linked
            >>>>
            >>>>>>> to GitHub for search purposes. This is similar to
            the webbug label.
            >>>>>>>
            >>>>>>> If these are agreeable, please add them to the
            contribution
            >>>>>>>
            >>>> instructions.
            >>>>
            >>>>>>> 4. What is https://github.com/javafxports/jfx-dev
            <https://github.com/javafxports/jfx-dev>? Newcomers can
            >>>>>>>
            >>>> confuse
            >>>>
            >>>>>>> it
            >>>>>>> with javafxports/openjdk-jfx.
            >>>>>>>
            >>>>>>> 5. When the mirror is fully ready and
            operational, we should
            >>>>>>>
            >> advertise
            >>
            >>>> on
            >>>>
            >>>>>>> community pages (like Reddit) to gather up
            contributors. Please keep
            >>>>>>>
            >> a
            >>
            >>>>>>> mental reminder when the time comes.
            >>>>>>>
            >>>>>>> Thanks to all who are working on this.
            >>>>>>>
            >>>>>>> - Nir
            >>>>>>>
            >>>>>>>
            >>>>>>>


Reply via email to