On Thu, 12 Dec 2019 19:48:37 GMT, Scott Palmer <swpal...@openjdk.org> wrote:
>> In that case, I recommend just doing the API get/set tests for `TextFlow` >> without creating a `Scene` or `Stage`. This won't need anything from the >> `StubToolkit`. > > In my attempts to address the issue with StubTextLayout I discovered bugs. > TextFlow is NOT properly overriding the tabSize of the Text nodes. If you > set the Text node tab size later, the layout reacts and adjusts to the > tabSize of the Text node even though it is contained in a TextFlow. > Whichever node changes the tabSize last affects the layout. I'm going to > have to study this more, but this change isn't ready at this point. Looks like I was missing a check for isSpan() in the invalidated method of the tabSize property of Text. I've fixed StubTextLayout to work with TextFlow now. ------------- PR: https://git.openjdk.java.net/jfx/pull/32
