On Thu, 12 Dec 2019 21:40:34 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1882:
>
>> 1881: return StyleableProperties.TAB_SIZE;
>> 1882: }
>> 1883: @Override protected void invalidated() {
>
> The `SimpleStyleableIntegerProperty` subclass can be used instead of
> `StyleableIntegerProperty` to make the code cleaner:
> new SimpleStyleableIntegerProperty(StyleableProperties.TAB_SIZE, Text.this,
> "tabSize", TextLayout.DEFAULT_TAB_SIZE);
>
> (This can be done for many places in the library)
I'd probably leave it as is for this PR, since it matches other attributes in
this file.
-------------
PR: https://git.openjdk.java.net/jfx/pull/32
