On Thu, 12 Dec 2019 21:16:32 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1273:
> 
>> 1272:     /**
>> 1273:      * The size of a tab stop in spaces.
>> 1274:      * Values less than 1 are treated as 1.
> 
> "tab stop" seems to be an uncommon term. Better are "horizontal tab" (used in 
> the 
> [JLS](https://docs.oracle.com/javase/specs/jls/se13/html/jls-3.html#jls-3.10.6)),
>  "tab character" (used in 
> [`Pattern`](https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/util/regex/Pattern.html),
>  "horizontal tabulation" or the like.

The terms "tab character" or "horizontal tab" refer to the ASCII tab character 
itself. Since a tab character isn't a fixed number of spaces, changing it to 
"size of a tab character" could be misleading. I'd be fine with another 
alternative, though, if someone could come up with a better one.

-------------

PR: https://git.openjdk.java.net/jfx/pull/32

Reply via email to