On Wed, 13 May 2020 11:20:25 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinDisposeContractTest.java >> line 159: >> >>> 158: {TreeTableView.class, }, >>> 159: {TreeView.class, }, >>> 160: }; >> >> Should these controls be included too: `Tooltip`, `HTMLEditor`, >> `ContextMenu` ? > > good catch :) > > Hmm .. thinking aloud: > > - all in web is a bit very different as a small layer on top of the > webEngine, usually off my radar > - the skinnable windows are no controls > > so the easy way out - which I would tend take :) - is to narrow the issue to > include only controls in controls. What do > you think? Agree that HTMLEditorSkin is a web module. let's keep it off radar :) TooltipSkin and ContextMenuSkin implement Skin and override the dispose() method. I think these Skins should also behave similar to other and can be included here in test. and also should consider them under cleanup issue [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364). Both the dispose() seem safe from NPE. ------------- PR: https://git.openjdk.java.net/jfx/pull/209