> some skins have not been guarding themselves against multiple calls to > dispose (see issue for details) > > Fixed by backing out off dispose if skinnable is null. Added test > (parameterized in control class) for all controls in > the controls package. Those that failed for the misbehaving skins before are > passing after the fix.
Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision: added test for ContextMenu/Tooltip skin as requested in review ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/209/files - new: https://git.openjdk.java.net/jfx/pull/209/files/2a362614..bd7e5b14 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/209/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/209/webrev.02-03 Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/209/head:pull/209 PR: https://git.openjdk.java.net/jfx/pull/209
