On Thu, 14 May 2020 09:02:26 GMT, Jeanette Winzenburg <faste...@openjdk.org>
wrote:
>> some skins have not been guarding themselves against multiple calls to
>> dispose (see issue for details)
>>
>> Fixed by backing out off dispose if skinnable is null. Added test
>> (parameterized in control class) for all controls in
>> the controls package. Those that failed for the misbehaving skins before are
>> passing after the fix.
>
> Jeanette Winzenburg has updated the pull request incrementally with one
> additional commit since the last revision:
>
> added test for ContextMenu/Tooltip skin as requested in review
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinPopupContractTest.java
line 50:
> 49: public void testContextMenuSkinDispose() {
> 50: ContextMenu tooltip = new ContextMenu();
> 51: tooltip.setSkin(new ContextMenuSkin(tooltip));
minor: `tooltip` should be renamed as `contextMenu`.
-------------
PR: https://git.openjdk.java.net/jfx/pull/209
