On Tue, 17 Nov 2020 11:14:49 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> thanks, that's probably working :) Didn't try, though, because verifying >> does require to setup all modules as projects (which I don't have, not being >> interested in swing/web/fxml) Plus this extra effort would only fix the >> _current_ usage of memorybuddy, leaving future inclusions in the other >> modules still broken. >> >> So where to go from here: >> >> - keep the scope of this issue focused on base/controls leaving the >> remaining projects to a new bug >> - widen the scope of this bug to include all projects (current users as well >> as future users) >> >> as you already rejected the first option, the second seems the way to go - >> that is, I will unassign the bug and close this PR? > >> Plus this extra effort would only fix the current usage of memorybuddy, >> leaving future inclusions in the other modules still broken. > > I think that this is fine. When future uses occur they should be accompanied > by the inclusion of the dependency, unless we know of plans to use it in > other modules. In any case, there is no need to close this PR. okay, so will simply unassign the issue and leave the PR open for someone else to complete - thanks for your input :) ------------- PR: https://git.openjdk.java.net/jfx/pull/352
