On Sun, 21 Mar 2021 04:13:48 GMT, Hsiafan <github.com+1498664+hsia...@openjdk.org> wrote:
> The convertNSStringToJString function convert NSString to Java String using > NewStringUTF，NewStringUTF accept modified-UTF8 encoded str。This fix using > UTF-16 encoding for converting. I'll review this. The fix seems fine at first glance. With your patch it uses a similar mechanism to the attributed string case; I'm curious why copying the string is needed in that case, but not in this case. What testing have you done to ensure that this will not cause any regressions? Perhaps @prrace or @jperedadnr or @johanvos could be a second reviewer? ------------- PR: https://git.openjdk.java.net/jfx/pull/436
