I've done a quick test and it looks good to me, however I'm still on macOS 10.15.6.
I've tried a virtual keyboard with both Spanish and with Chinese input, and I could verify that the change produces the same jStr result as before. However I'm not sure if I can try those extended emoji characters? On Wed, Mar 24, 2021 at 1:13 PM Kevin Rushforth <k...@openjdk.java.net> wrote: > On Sun, 21 Mar 2021 04:13:48 GMT, Hsiafan <github.com+ > 1498664+hsia...@openjdk.org> wrote: > > > The convertNSStringToJString function convert NSString to Java String > using NewStringUTF，NewStringUTF accept modified-UTF8 encoded str。This fix > using UTF-16 encoding for converting. > > I'll review this. The fix seems fine at first glance. With your patch it > uses a similar mechanism to the attributed string case; I'm curious why > copying the string is needed in that case, but not in this case. > > What testing have you done to ensure that this will not cause any > regressions? > > Perhaps @prrace or @jperedadnr or @johanvos could be a second reviewer? > > ------------- > > PR: https://git.openjdk.java.net/jfx/pull/436 > --
