On Thu, 1 Apr 2021 20:13:56 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> I've test on macOS 11.2.3 with Chinese input method, including ascii chars, >> CJK chars, emojis, and inputing ascii/cjk chars+emojis together. All works >> as expected. >> >> The memory allocation in NSAttributedString could be eliminated either, >> AFAIK. I haven't tested it, do not know how to input a NSAttributedString. > > As mentioned earlier, the fix works fine for me on macOS 10.15.6. > > About the case of `NSAttributedString`, yes it could be refactored too. > However, I couldn't test it either, as I'm not sure how we could get "rich > text" typed into a JavaFX input control. In any case, maybe it is better to > do it in a follow-up issue? Yeah, I don't recommend doing anything for the attributed string case. It's a largely-unrelated change that I only mentioned earlier because I noticed that the new code was different in that regard. If we do anything at all with the attributed string case, it would definitely want to be done in a follow-up issue (and I don't really see a need to do anything). ------------- PR: https://git.openjdk.java.net/jfx/pull/436
