On Mon, 29 Mar 2021 17:17:30 GMT, Nir Lisker <[email protected]> wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed trailing whitespace
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
> 246:
>
>> 244: /**
>> 245: * Registers an operation to perform when the given {@code
>> Observable} sends an invalidation event.
>> 246: * Does nothing if observable or operation is {@code null}.
>
> I would write "Does nothing if either {@code observable} or {@code operation}
> are {@code null}"
Done. Also changed leading upper-case of observable in first sentence to
lower-case - for consistency because I don't see a difference between both,
blind me? ;)
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
> 265:
>
>> 263: * Unregisters all operations that have been registered using
>> 264: * {@link #registerInvalidationListener(Observable, Consumer)}
>> 265: * for the given observable.
>
> If the parameter can be `null`, mention what happens like in
> `registerInvalidationListener`.
done
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
> 270:
>
>> 268: * may be {@code null}
>> 269: * @return a composed consumer that performs all removed operations
>> or
>> 270: * {@code null} if none has been registered or the observable is
>> {@null}
>
> * Comma before the first "or"
> * "none *have* been"
thanks :) Done.
-------------
PR: https://git.openjdk.java.net/jfx/pull/409
