On Wed, 24 Mar 2021 23:39:13 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
> 264:
>
>> 262: * {@link #registerInvalidationListener(Observable, Consumer)}
>> 263: * for the given observable. The end result is that the given
>> observable is no longer observed by any of the invalidation
>> 264: * listeners, but it may still have additional listeners registered
>> on it through means outside of
>
> Maybe instead of "The end result..." something like:
>
> Only listeners that were registered using the aforementioned method are
> removed; listeners registered through other means are unaffected.
did a complete overhaul - thinking that clarification is no longer needed:
stating to remove all that have been registered with the registration method
should be enough (there is no other way to inject additional consumers). I
think that trying to be over-clear on removing _all_ was a result of the
debates at the time it was introduced (we did a bit of dancing then ;)
-------------
PR: https://git.openjdk.java.net/jfx/pull/409
