On Fri, 18 Jun 2021 10:10:42 GMT, Ajit Ghaisas <[email protected]> wrote:
>> This PR enables Tree- and TableCells to also check the row editability when >> an edit should happen. With this a Tree- or TableCell is not editable, when >> the row where the cell is in is not. >> >> While this PR fixes the problem described in the ticket, it does not fix the >> example. >> This is due the example uses the **CheckBoxTableCell**, which is a >> ready-to-use subclass of **TableCell**. >> >> While looking into this, I found out that multiple sub implementations still >> have this issue, but the fix is not always the same, e.g. CheckBoxTableCell >> should disable the CheckBox (in **updateItem**), while the >> ChoiceBoxTableCell should check the row editability in the **startEdit** >> method (like this PR does). >> >> I created a follow-up issues for fixing all the sub Tree- and TableCell >> implementation which do not count the row editability in: >> [JDK-8268295](https://bugs.openjdk.java.net/browse/JDK-8268295) > > modules/javafx.controls/src/main/java/javafx/scene/control/TableCell.java > line 310: > >> 308: (table != null && !table.isEditable()) || >> 309: (column != null && !column.isEditable()) || >> 310: (row != null) && !row.isEditable()) { > > Incorrect Line ---- "(row != null) && !row.isEditable())" > Correction required ---- "(row != null && !row.isEditable()))" > > Refer similar line which is rightly implemented in TreeTableCell.java. darn .. you certainly have the better eyes :))) ------------- PR: https://git.openjdk.java.net/jfx/pull/529
