On Tue, 22 Jun 2021 06:28:49 GMT, Marius Hanl <[email protected]> wrote:
>> This PR enables Tree- and TableCells to also check the row editability when >> an edit should happen. With this a Tree- or TableCell is not editable, when >> the row where the cell is in is not. >> >> While this PR fixes the problem described in the ticket, it does not fix the >> example. >> This is due the example uses the **CheckBoxTableCell**, which is a >> ready-to-use subclass of **TableCell**. >> >> While looking into this, I found out that multiple sub implementations still >> have this issue, but the fix is not always the same, e.g. CheckBoxTableCell >> should disable the CheckBox (in **updateItem**), while the >> ChoiceBoxTableCell should check the row editability in the **startEdit** >> method (like this PR does). >> >> I created a follow-up issues for fixing all the sub Tree- and TableCell >> implementation which do not count the row editability in: >> [JDK-8268295](https://bugs.openjdk.java.net/browse/JDK-8268295) > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review comments Marked as reviewed by aghaisas (Reviewer). ------------- PR: https://git.openjdk.java.net/jfx/pull/529
