On Sun, 6 Jun 2021 12:44:00 GMT, Marius Hanl <[email protected]> wrote:
> This PR enables Tree- and TableCells to also check the row editability when > an edit should happen. With this a Tree- or TableCell is not editable, when > the row where the cell is in is not. > > While this PR fixes the problem described in the ticket, it does not fix the > example. > This is due the example uses the **CheckBoxTableCell**, which is a > ready-to-use subclass of **TableCell**. > > While looking into this, I found out that multiple sub implementations still > have this issue, but the fix is not always the same, e.g. CheckBoxTableCell > should disable the CheckBox (in **updateItem**), while the ChoiceBoxTableCell > should check the row editability in the **startEdit** method (like this PR > does). > > I created a follow-up issues for fixing all the sub Tree- and TableCell > implementation which do not count the row editability in: > [JDK-8268295](https://bugs.openjdk.java.net/browse/JDK-8268295) fix looks good, verified new tests failing before and all tests passing after left minor comments to the test methods modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java line 329: > 327: public void testCellInUneditableRowIsNotEditable() { > 328: table.setEditable(true); > 329: TableRow row = new TableRow(); fix generic warning modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableCellTest.java line 641: > 639: row.setEditable(false); > 640: > 641: TreeTableColumn treeTableColumn = new TreeTableColumn(); fix generic warning ------------- Changes requested by fastegal (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/529
