On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property, this PR provides public
>> support for setting the background color of a WebPage, by adding a
>> `pageFill` property, and a CSR is required.
>>
>> The color for the background, that can be opaque, transparent or with any
>> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>>
>> Unit tests and a system test are provided.
>
> Jose Pereda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Set since 18
The API for the new property looks fine. I left a couple comments on the
javadoc.
You can create a Draft CSR when you get a chance. You still need to update
`cssref.html` and that will need to be part of the CSR.
modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 702:
> 700: /**
> 701: * Specifies the background color of the webPage, allowing
> 702: * some or full transparency.
You might want to split this into two sentences, with the part about allowing
for transparent being in the second sentence. Another thing you should indicate
is how this interacts with the background color in the HTML file (I presume the
one in the file takes precedence?). Also "web page" should be two words.
modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 704:
> 702: * some or full transparency.
> 703: *
> 704: * Default color: White
Use an `@defaultValue` javadoc tag here:
@defaultValue {@code Color.WHITE}
-------------
PR: https://git.openjdk.java.net/jfx/pull/563
