On Thu, 12 Aug 2021 21:28:53 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Set since 18
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 702:
> 
>> 700:     /**
>> 701:      * Specifies the background color of the webPage, allowing
>> 702:      * some or full transparency.
> 
> You might want to split this into two sentences, with the part about allowing 
> for transparent being in the second sentence. Another thing you should 
> indicate is how this interacts with the background color in the HTML file (I 
> presume the one in the file takes precedence?). Also "web page" should be two 
> words.

Done

> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 704:
> 
>> 702:      * some or full transparency.
>> 703:      *
>> 704:      * Default color: White
> 
> Use an `@defaultValue` javadoc tag here:
> 
> 
>     @defaultValue {@code Color.WHITE}

Done

-------------

PR: https://git.openjdk.java.net/jfx/pull/563

Reply via email to