On Mon, 23 Aug 2021 14:59:57 GMT, Jose Pereda <jper...@openjdk.org> wrote:
> Do I need to update its code with the latest changes of this PR? Yes, although you can "batch up" the changes if you like until the review is far enough along that the API is unlikely to change. One comment on the CSR is that the specification section is concerned with interface changes. So you can (and should) elide the body of any public methods and just leave the method signature and API docs. For properties, the private field is often included in the CSR, since that's what you hang the API docs on. For the styleable property, it should be sufficient to include the diffs for `cssref.html` once you have them (see below). > As for the cssref.html update, do I add it as a commit to this PR, or as a > new PR with the CSR id? Add it as a commit to this PR (btw, the JBS ID of the CSR is never used directly as an issue resolved by a PR; it is instead associated with a bug or enhancement that is). ------------- PR: https://git.openjdk.java.net/jfx/pull/563
