On Fri, 1 Oct 2021 13:10:29 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit doesn't switch the cell >> into editing mode >> >> Added tests that failed/passed before/after the fix. Note that for Tree-, >> Table-, TreeTableCell one of the added tests would be a false green due to >> those cells not updating the editing location on its control >> [JDK-8187474](https://bugs.openjdk.java.net/browse/JDK-8187474), so it's >> ignore until that's fixed. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java > line 726: > >> 724: int editingRow = table.getItems().size(); >> 725: cell.updateIndex(editingRow); >> 726: List<CellEditEvent> events = new ArrayList<>(); > > `events` is effectively unused here, maybe you forgot the assert here? actually, no: forgot to removed the unused list ;) Good catch! ------------- PR: https://git.openjdk.java.net/jfx/pull/636
