On Fri, 1 Oct 2021 14:59:02 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> The misbehavior happens if (super) startEdit didn't succeed (== >> !cell.isEditing): >> >> - must not fire editStart event >> - must not update control's editing location >> >> fix is to back out of startEdit if super.startEdit doesn't switch the cell >> into editing mode >> >> Added tests that failed/passed before/after the fix. Note that for Tree-, >> Table-, TreeTableCell one of the added tests would be a false green due to >> those cells not updating the editing location on its control >> [JDK-8187474](https://bugs.openjdk.java.net/browse/JDK-8187474), so it's >> ignore until that's fixed. > > Jeanette Winzenburg has updated the pull request incrementally with one > additional commit since the last revision: > > test cleanup, following review comments Looks good! ------------- Marked as reviewed by mhanl (Author). PR: https://git.openjdk.java.net/jfx/pull/636
