On Sat, 5 Feb 2022 12:51:58 GMT, Jay Bhaskar <d...@openjdk.java.net> wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line
>> 859:
>>
>>> 857: if (page->isClosing() && m_localStorage)
>>> 858: return m_localStorage.get();
>>> 859:
>>
>> If you make the earlier modification I suggested, then you don't need this
>> block.
>
> We must check if localstorage setting is disabled, then return nullptr
> first.,as below
> if (!page->settings().localStorageEnabled())
> return nullptr;
>
> and there after the section
> if (page->isClosing() && m_localStorage)
> return m_localStorage.get();
> would become as below
> if (m_localStorage)
> return m_localStorage.get();
in recent code base (webkit upgrade)the localstorage is false ,
@@ -1579,7 +1579,7 @@ NeedsSiteSpecificQuirks:
WebKit:
default: true
WebCore:
- default: false
+ default: true
So , it needs to be enable also.
-------------
PR: https://git.openjdk.java.net/jfx/pull/703
