On Fri, 28 Jan 2022 00:09:11 GMT, Kevin Rushforth <[email protected]> wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into PRLocalstorage
>> - Window.close(), Fix for localstoarge
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 857:
>
>> 855: return m_localStorage.get();
>> 856: }
>> 857:
>
> This will change the behavior for the case where page is null or where the
> page is valid, but not closing. I think you should partially revert this part
> of the fix, restoring it as follows:
>
>
> if (m_localStorage)
> return m_localStorage.get();
I still think you need to restore this block, but without the check for
`isClosing`.
> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
> line 60:
>
>> 58: assertNotNull(webEngine.executeScript("localStorage;"));
>> 59: getEngine().executeScript("window.close();");
>> 60: assertNotNull(webEngine.executeScript("localStorage;"));
>
> It seems useful to verify the contents by writing something before the window
> is closed, and then verifying that the same value can be read.
Can you comment on this?
-------------
PR: https://git.openjdk.java.net/jfx/pull/703
