On Sat, 5 Feb 2022 14:58:25 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> in recent code base (webkit upgrade)the localstorage is false , >> @@ -1579,7 +1579,7 @@ NeedsSiteSpecificQuirks: >> WebKit: >> default: true >> WebCore: >> - default: false >> + default: true >> >> So , it needs to be enable also. > > 1. My point was that if you initially check for `m_localStorage` being > non-null, without the check for `isClosing` (see my earlier comment), then > you don't need to check it here. > > 2. Regarding the enabling of local storage in WebCore, are you seeing any > problems as a result of not having it enabled? yes, in case of not enable , in any case localstorage would be null ------------- PR: https://git.openjdk.java.net/jfx/pull/703
