On Fri, 22 Jul 2022 19:22:48 GMT, Andy Goryachev <[email protected]> wrote:

> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
> 
> no code changes for Skinnable.setSkin(Skin) yet.

modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line 
244:

> 242:             // check whether the skin is for right control
> 243:             if (skin != null) {
> 244:                 if(skin.getSkinnable() != Control.this) {

minor: Perhaps write this as one `if` (saves an indent level) or at least make 
the space after `if` consistent between the two.

-------------

PR: https://git.openjdk.org/jfx/pull/845

Reply via email to