On Wed, 27 Jul 2022 19:06:30 GMT, Michael Strauß <[email protected]> wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java
> line 269:
>
>> 267: if(skin != null) {
>> 268: skin.install();
>> 269: }
>
> You should probably also add the check for PopupControl.
sorry, what check?
if you mean
if (skin != null) {
if(skin.getSkinnable() != Control.this) {
we can't because PopupControl violates the 1:1 rule.
-------------
PR: https://git.openjdk.org/jfx/pull/845
