On Wed, 27 Jul 2022 06:57:16 GMT, John Hendrikx <[email protected]> wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line
> 244:
>
>> 242: // check whether the skin is for right control
>> 243: if (skin != null) {
>> 244: if(skin.getSkinnable() != Control.this) {
>
> minor: Perhaps write this as one `if` (saves an indent level) or at least
> make the space after `if` consistent between the two.
added space.
with your permission, I'd rather have one statement per line - it's easier to
step through in a debugger.
-------------
PR: https://git.openjdk.org/jfx/pull/845
