On Tue, 29 Nov 2022 18:12:26 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' of https://git.openjdk.org/jfx into >> feature/fix-easy-warnings-in-controls >> - Fix some indents and put declarations on one line where possible >> - Replace StubToolkit casts with asserts (2) >> - Revert read only property instanceof checks >> >> Added SuppressWarnings("cast") as these checks should be retained >> - Replace StubToolkit casts with asserts >> - Revert instanceof changes and replace with null checks >> - Revert "Fix warnings in fxml" >> >> This reverts commit b148aa3cc8a4676167a9eb8a023cddce3de116e7. >> - Fix warnings in fxml >> - Add workaround for JDK-8297428 (javac compiler type inference bug) >> - Remove unused imports >> - ... and 13 more: https://git.openjdk.org/jfx/compare/fbad15d1...1697bd1d > > modules/javafx.controls/src/main/java/javafx/scene/control/TableColumn.java > line 134: > >> 132: * @since JavaFX 2.0 >> 133: */ >> 134: public class TableColumn<S,T> extends TableColumnBase<S,T> { > > This class is part of the public API, so this change must be reverted. The > list of implemented classes shows up in the class file and in the javadoc. I > suspect that this might be a compatible change, but would need to > double-check to be certain. In any case, I don't want this change made. interesting - there is technically no change, as `TableColumnBase` implements `EventTarget`. @hjohn does javadoc produce a different result? ------------- PR: https://git.openjdk.org/jfx/pull/959
