On Tue, 22 Nov 2022 12:08:44 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> Note: I ran into a `javac` compiler bug while replacing types with diamond > operators (ecj has no issues). I had two options, add a > `SuppressWarnings("unused")` or to use a lambda instead of a method reference > to make `javac` happy. I choose the later and added a comment so it can be > fixed once the bug is fixed. I've reported the issue here: > https://bugs.openjdk.org/browse/JDK-8297428 > > - Remove unsupported/unnecessary SuppressWarning annotations > - Remove reduntant type specifications (use diamond operator) > - Remove unused or duplicate imports > - Remove unnecessary casts (type is already correct type or can be autoboxed) > - Remove unnecessary semi-colons (at end of class definitions, or just > repeated ones) > - Remove redundant super interfaces (interface that is already inherited) > - Remove unused type parameters > - Remove declared checked exceptions that are never thrown > - Add missing `@Override` annotations This pull request has now been integrated. Changeset: 2fa9f4b9 Author: John Hendrikx <jhendr...@openjdk.org> Committer: Nir Lisker <nlis...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/2fa9f4b9e53a43de0676631ab5d93334d2a3b2dd Stats: 2290 lines in 319 files changed: 159 ins; 303 del; 1828 mod 8297414: Remove easy warnings in javafx.controls Reviewed-by: angorya, kcr, nlisker ------------- PR: https://git.openjdk.org/jfx/pull/959