On Tue, 29 Nov 2022 21:58:38 GMT, John Hendrikx <[email protected]> wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac` happy. I choose the later and added a comment so
>> it can be fixed once the bug is fixed. I've reported the issue here:
>> https://bugs.openjdk.org/browse/JDK-8297428
>>
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just
>> repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert redundant super interface changes
> As far as I can see, the tests should be run with the system property
> javafx.toolkit set to test.com.sun.javafx.pgstub.StubToolkit. Without it,
> many tests fail (probably thousands). Verifying this in each test that
> happens to require StubToolkit seems overkill -- it could be a single test in
> the root somewhere that checks this (or not at all).
This is what I mentioned when the discussion was brought up. The toolkit used
is tests-wide, not just per class, so it makes sense to check it once when
running a test suit.
-------------
Marked as reviewed by nlisker (Reviewer).
PR: https://git.openjdk.org/jfx/pull/959
