On Thu, 30 Mar 2023 13:34:41 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify ImmutablePseudoClassSetsCache and avoid an unnecessary copy > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 231: > >> 229: } >> 230: >> 231: final int element = getIndex(t) / Long.SIZE; > > `getIndex(t)` is called twice here and below, maybe we should consider > calling it once and save the result in a local variable instead? I fixed this. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1076#discussion_r1153760022
