On Mon, 24 Apr 2023 21:23:07 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> > I only looked at `PseudoClassState`, and it will rarely exceed the 64 bits > > that are available > > I wonder if this should be reflected in a comment somewhere, may be in > 'Assumptions' section? This is in regards to a possible micro-optimization where it may need to change the array size of the bit set a few times if a copy needs to be made, but it will function correctly all the same. As far as assumptions go, `BitSet` is/was full of them, and I would not recommend its use for any new code. If anything, I'd add a big warning on top of this class with caps. Furthermore, this PR is primarily about preventing making copies in the first place so the need for this micro-optimization is less pressing than it ever was before. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1076#issuecomment-1521188864
