On Tue, 25 Apr 2023 17:26:54 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Avoid using Lambda in ImmutablePseudoClassSetsCache.of()
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 44:
>
>> 42: * which makes matching faster.
>> 43: */
>> 44: abstract class BitSet<T> extends AbstractSet<T> implements
>> ObservableSet<T> {
>
> Since this is an internal class, would it be possible / make sense to rename
> it, to avoid confusion with the real Slim^H^H^H^H BitSet? StyleBitSetBase or
> some such?
BitSet name still bugs me.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1076#discussion_r1224829679
