On Fri, 9 Jun 2023 22:08:53 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> one question: since the JBS talks about memory leak, is it possible to devise > a test for that? > > otherwise, looks good. It's not really a memory leak, the amount of memory that it can take can just be quite large in the right circumstances. Once it has been allocated though, it will remain the same and won't grow further. The test in `ImmutablePseudoClassSetsCacheTest` confirms (at a unit level) that it is indeed caching sets that are the same. It may be possible to create a higher level test as well, similar to the code example in the ticket. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1076#issuecomment-1585302657
