On Fri, 18 Aug 2023 22:17:15 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> In the Control hierarchy, all property accessor methods must be declared >> `final`. >> >> Added a test to check for missing `final` keyword and added the said keyword >> where required. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments Um, "classpath"? JavaFX is a collection of modules that are found on the module path. In any case, this seems better done as follow-up issue, if you want to file one. Btw, having an automatic scan of "everything" seems like overkill, and isn't really desirable, so if you do want to go down this route, I'd keep it simple. Since any non-exported package (i.e., any pacakge that isn't under `javafx.**`) will already need to be explicitly listed in the `test/addExports` file, and since we so very rarely add a new package, you might consider having a hard coded List of packages that you enumerate looking for all classes in each package for ones with properties. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1213#issuecomment-1684519981
