On Mon, 21 Aug 2023 15:27:44 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> these classes (in javafx.scene.control.cell) are public and in the Control > hierarchy, so are subject of the 'final' limitation. I'm confused. Which classes should appear in this list exactly (what are the rules to determine that)? > edit: about the test itself - I see little difference between the two > version, but will gladly use your version if you feel strongly about it. I don't, I just think it's more readable. Fine to leave as is. What I might strongly suggest is extracting the `checkModifiers` method that is used in 2 places in your version. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300703992 PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300705000
