On Sun, 20 Aug 2023 06:16:06 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java > line 103: > >> 101: // >> https://stackoverflow.com/questions/28678026/how-can-i-get-all-class-files-in-a-specific-package-in-java >> 102: private Class[] allControlClasses() { >> 103: return new Class[] { > > I was also thinking that these should be generated by the contents of the > package. When I looked at javafx.scene.control I saw classes that weren't > controls, but were used by them, so they would need to be removed. So it's a > question of whitelist vs. blacklist. > > In any case, I'm not sure why you're using an array here. `Set.of` seems more > suitable and will also check for duplicate entries. Respectfully disagree - these classes (in javafx.scene.control.cell) are public and in the Control hierarchy, so are subject of the 'final' limitation. There are no duplicate classes. The bigger problem is (my) inability to extract the list/set/array of classes automatically. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300284037
