On Wed, 13 Sep 2023 15:32:15 GMT, Lukasz Kostyra <[email protected]> wrote:
>> tests/system/src/test/java/test/robot/javafx/stage/AttributesTest.java line
>> 48:
>>
>>> 46: import static test.util.Util.TIMEOUT;
>>> 47:
>>> 48: public class AttributesTest extends VisualTestBase {
>>
>> a brief javadoc explaining what this test does would be nice.
>> also, perhaps the class name could be more descriptive, i.e.
>> StageAttributesTest or something like that.
>
> I'll add the javadoc.
>
> I skipped the `Stage` prefix since this test is in a directory of
> `Stage`-related tests. Should I still add it despite that?
The more specific the class name, the better, I think (and also, specific names
reduce collisions)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1240#discussion_r1324715928
