On Wed, 13 Sep 2023 15:31:15 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> tests/system/src/test/java/test/robot/javafx/stage/AttributesTest.java line >> 56: >> >>> 54: private static final Color TOP_COLOR = Color.RED; >>> 55: >>> 56: private static final double TOLERANCE = 0.07; >> >> just curious: how did we arrive at this value? > > I borrowed it from `IconifyTest.java` which most of this file is based on. > Hard for me to say why is it exactly that. This constant, with the same value of `0.07`, is repeated in most of our robot screen capture tests. It seems a good candidate for moving it to the `VisualTestBase` parent class, as a future test enhancement. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1240#discussion_r1326304679
