On Fri, 15 Sep 2023 12:20:11 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> tests/system/src/test/java/test/robot/javafx/stage/AttributesTest.java line >> 111: >> >>> 109: >>> 110: topStage.setIconified(true); >>> 111: }); >> >> This will show the stage before setting it as iconified. Testing correct >> behavior for a stage that is initially iconified/maximized/fullScreen prior >> to showing the stage is the main purpose of this test enhancement, so you >> will need to do something like split the creation and showing of the stages >> into separate methods or pass flags for the initial state of those three >> attributes as arguments to the setupStages method. > > Seems like testing both pre- and post-show behaviors would be the best > option. I'll expand this to test both paths. The post-show behavior is already covered by other tests (e.g., IconifyTest). It wouldn't hurt to provide additional tests if easy, but it's not really necessary. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1240#discussion_r1327247844
