On Fri, 6 Oct 2023 05:20:06 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> allowed characters
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/PasswordFieldBehaviorTest.java
> line 63:
>
>> 61: @Override
>> 62: public void testCopy() {
>> 63: // copy is disabled
>
> An empty test case simply gets reported as passed.
> Do you want to assert that the "copy is disabled" somehow?
> There are a few other test cases in this file which are of similar nature.
> If they need to be worked upon in future, we can mark them as TODO.
> If they are just for information, we can keep the entire test cases commented
> so that they do not execute and report as passed.
good point, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1221#discussion_r1349169611
