On Thu, 12 Oct 2023 13:52:25 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 44 commits: >> >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8314906.behavior.test >> - allowed characters >> - Merge remote-tracking branch 'origin/master' into 8314906.behavior.test >> - check >> - test typing >> - Merge remote-tracking branch 'origin/master' into 8314906.behavior.test >> - cleanup >> - key modifier >> - Merge remote-tracking branch 'origin/8314906.behavior.test' into >> 8314906.behavior.test >> - ... and 34 more: https://git.openjdk.org/jfx/compare/25862787...8b8112b8 > > doc-files/behavior/PasswordField.md line 3: > >> 1: # PasswordField Behavior >> 2: >> 3: ## Key Binginds > > Minor: typo "Binginds" The first rule of submitting scientific publications for a review: make an obvious spelling error in the title. :-) thanks! > doc-files/behavior/TextField.md line 72: > >> 70: Notes: >> 71: >> 72: 1. Base class mappings modified by the TextField class are highlighted >> in bold. > > None of the key mappings are highlighted in bold in this file. none have been modified, so we are ok. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1221#discussion_r1357121963 PR Review Comment: https://git.openjdk.org/jfx/pull/1221#discussion_r1357124711
