On Thu, 12 Oct 2023 17:08:39 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Creating the first batch of tests and testing framework that enables writing >> behavior tests for javafx controls, focusing on key bindings. The idea is >> to make writing such tests a simple process. >> >> This PR deals with the descendants of TextInputControl (TextField, >> PasswordField, TextArea). Most of the tests are headless, but in some cases >> (TextArea) a headful test is required because the behavior needs rendered >> text to function (example: page up / page down / line start / line end and >> the like). >> >> The tests exercise the key bindings registered by the Skin (or, rather the >> associated Behavior) at least once, and sometimes more than once. >> >> Some mappings cannot be tested due to Robot not supporting keypad events >> (created [JDK-8316307](https://bugs.openjdk.org/browse/JDK-8316307)). >> >> In addition, the key bindings are documented in /doc-files/behavior markdown >> documents: >> >> https://github.com/andy-goryachev-oracle/jfx/blob/8314906.behavior.test/doc-files/behavior/PasswordField.md >> https://github.com/andy-goryachev-oracle/jfx/blob/8314906.behavior.test/doc-files/behavior/TextArea.md >> https://github.com/andy-goryachev-oracle/jfx/blob/8314906.behavior.test/doc-files/behavior/TextField.md >> https://github.com/andy-goryachev-oracle/jfx/blob/8314906.behavior.test/doc-files/behavior/TextInputControl.md > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments LGTM ------------- Marked as reviewed by kpk (Committer). PR Review: https://git.openjdk.org/jfx/pull/1221#pullrequestreview-1675611628