On Wed, 17 Sep 2025 23:32:08 GMT, Kevin Rushforth <[email protected]> wrote:
>> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ErrorLoggingUtility.java
>> line 36:
>>
>>> 34: import com.sun.javafx.logging.PlatformLogger.Level;
>>> 35:
>>> 36: public class ErrorLoggingUtility {
>>
>> I see you left in the name change to `ErrorLoggingUtility`. I was hoping
>> you'd revert that along with the other changes to this file, since they are
>> now unrelated and make the PR much larger to review. Yes, I know it's a
>> mechanical change, but I find it hard to see what has "really" changed now.
>>
>> Suggestion: revert the name change to this utility, since it is no longer
>> relevant.
>
> Further, there are at least some files in javafx.base that are unchanged
> except for this name change, a reordering of imports, and a copyright year
> update. See
> `modules/javafx.base/src/test/java/test/javafx/binding/BindingsArrayTest.java`
> which has a large number of changes, but I think the whole file would be
> reverted and untouched (meaning no need for 2025) if you revert the name
> change.
yikes. to be be renamed in JDK-8367995
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2359838226
