On Thu, 18 Sep 2025 15:40:41 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   cleanup
>
> modules/javafx.base/src/test/java/test/javafx/util/OutputRedirect.java line 
> 221:
> 
>> 219:     }
>> 220: 
>> 221:     // should I leave this test here?  to test the test?
> 
> Seems reasonable.

Although, I would remove or reword the comment asking whether you should leave 
it if you've decided to do so.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2360496902

Reply via email to