On Thu, 18 Sep 2025 18:00:47 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> modules/javafx.base/src/test/java/test/javafx/util/OutputRedirect.java line 
>> 161:
>> 
>>> 159:             map((s) -> findException(s)).
>>> 160:             forEach((c) -> {
>>> 161:                 if (c != null) {
>> 
>> Minor suggestion: filter for non-null Strings before the `forEach` rather 
>> than checking for non-null in the `forEach` ?
>
> my version is _more efficient_ :-)

I doubt it. Anyway, it doesn't really matter all that much.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1897#discussion_r2360594144

Reply via email to