On Thu, 23 Oct 2025 18:04:28 GMT, Kevin Rushforth <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make leftSystemInset/rightSystemInset/minSystemHeight attached properties > > modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line > 888: > >> 886: this.leftSystemInset = new ReadOnlyObjectWrapper<>(stage, >> "HeaderBar.leftSystemInset", EMPTY); >> 887: this.rightSystemInset = new ReadOnlyObjectWrapper<>(stage, >> "HeaderBar.rightSystemInset", EMPTY); >> 888: this.minSystemHeight = new ReadOnlyDoubleWrapper(stage, >> "HeaderBar.minSystemHeight"); > > Should the classname prefix in the property `name` be fully qualified? If it > were, then a utility could find the corresponding method(s) from the bean > using the convention that if a name contains a `.`, it is an attached > property with the bean being an argument to the named (static) method. This is pending a discussion on the [mailing list](https://mail.openjdk.org/pipermail/openjfx-dev/2025-November/057431.html). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1936#discussion_r2535591882
