On Fri, 14 Nov 2025 18:23:54 GMT, Andy Goryachev <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Make leftSystemInset/rightSystemInset/minSystemHeight attached properties
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 
> 70:
> 
>> 68:  * <p>
>> 69:  * {@code HeaderBar} is a layout container that allows applications to 
>> place scene graph nodes in three areas:
>> 70:  * {@link #leftProperty() left}, {@link #centerProperty() center}, and 
>> {@link #rightProperty() right}.
> 
> perhaps there should be a separate section explaining that the left/right 
> nodes get switched visually in the RTL mode?  And/or mention that "left" 
> really means "leading", and "right" really means "trailing"?

I've added a section to the package documentation, because it is applicable for 
all layout containers with named regions, not just `HeaderBar`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1936#discussion_r2529424642

Reply via email to